[
https://issues.apache.org/jira/browse/HBASE-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13864375#comment-13864375
]
takeshi.miao commented on HBASE-10147:
--------------------------------------
hi [~gustavoanatoly]
{quote}
1 - Rename method;
2 - Change output messages;
{quote}
The public API for interface _Sink_ is broken again if you do this way... but I
not so insist this due to as I said previously
bq.I not sure whether it is acceptable code change, that is ok if stack says
ok, due to I think currently that not many users really extend this interface
... ?
[~stack] how do you think ?
otherwise, your change is fine for me ;)
> Canary additions
> ----------------
>
> Key: HBASE-10147
> URL: https://issues.apache.org/jira/browse/HBASE-10147
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: Gustavo Anatoly
> Attachments: HBASE-10147-v2.patch, HBASE-10147-v3.patch,
> HBASE-10147-v4.patch, HBASE-10147.patch, HBASE-10147.patch,
> HBASE-10147.patch, HBASE-10147.patch
>
>
> I've been using the canary to quickly identify the dodgy machine in my
> cluster. It is useful for this. What would make it better would be:
> + Rather than saying how long it took to get a region after you have gotten
> the region, it'd be sweet to log BEFORE you went to get the region the
> regionname and the server it is on. I ask for this because as is, I have to
> wait for the canary to timeout which can be a while.
> + Second ask is that when I pass the -t, that when it fails, it says what it
> failed against -- what region and hopefully what server location (might be
> hard).
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
