[ 
https://issues.apache.org/jira/browse/HBASE-10356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13893084#comment-13893084
 ] 

stack commented on HBASE-10356:
-------------------------------

[~sershe] I looked at the  smaller patch.

Why does Action have to know about replicaid?  Currently it is the outline of a 
Get, Put, or Delete just for keeping up an index so we can run multi of these 
in a request... and make sense of the result and exceptoins when they come 
back.   replicaid stuff should be going on elsewhere where we are figuring the 
destination server for this Action?  Won't you want to be able to take an 
Action that fails one replica and point it at another replica (w/o having to 
update the replica it is carrying?)

These are right?

-    @Override

On AsyncProcess knowing about replicas, again, shouldn't it be a read replica 
driver class that runs the AsyncProcess making sense of results and 
rescheduling against new replicas if failure rather than doctoring of 
AsyncProcess?

Its hard to figure how this works.  Is there a bit of doc on it somewhere?

A AsyncRequestFutureImpl has a ReplicaRunnable.  What is a ReplicaRunnable?

SingleServerRunnable is what happens when no read replicas?  Why ain't 
SingleServerRunnable an instance of ReplicaRunnable only replicas==1?

I skimmed the rest.  I think you get my main point.

> Failover RPC's for multi-get 
> -----------------------------
>
>                 Key: HBASE-10356
>                 URL: https://issues.apache.org/jira/browse/HBASE-10356
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Client
>            Reporter: Enis Soztutar
>            Assignee: Sergey Shelukhin
>             Fix For: 0.99.0
>
>         Attachments: HBASE-10356.reference.patch, HBASE-10356.reference.patch
>
>
> This is extension of HBASE-10355 to add failover support for multi-gets. 



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to