[ 
https://issues.apache.org/jira/browse/HBASE-10356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13893749#comment-13893749
 ] 

stack commented on HBASE-10356:
-------------------------------

Can we fix the naming?  An Action instance with a method named getAction is 
confusing (not you I know...)

Do I have the model wrong then? This Action is for accounting on how this 
'Action' did in the Multi request, right?   My thinking is that server and 
region accounting is done outside of the Action usually.  I'd think which 
replica would be done there w/o needing to mark this index on the Multi call.

bq. Second, AP currently already manages finding the locations and grouping of 
request, it wouldn't make sense to have another external place to manage 
replica locations separately and group requests separately for replica case. 

AP is involved as it is.  I'd think that read replica management would be a 
cilent of AP rather than threaded through (but as said above, I am not clear 
what is going on here...)

The new Runnables need explanatory comments and better names (?).  Should the 
two types be related?  Subclass?   Do we need two Callable types?

Thanks Sergey.





> Failover RPC's for multi-get 
> -----------------------------
>
>                 Key: HBASE-10356
>                 URL: https://issues.apache.org/jira/browse/HBASE-10356
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Client
>            Reporter: Enis Soztutar
>            Assignee: Sergey Shelukhin
>             Fix For: 0.99.0
>
>         Attachments: HBASE-10356.reference.patch, HBASE-10356.reference.patch
>
>
> This is extension of HBASE-10355 to add failover support for multi-gets. 



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to