[ 
https://issues.apache.org/jira/browse/HBASE-10479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13893995#comment-13893995
 ] 

Hadoop QA commented on HBASE-10479:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12627501/HBASE-10479.patch
  against trunk revision .
  ATTACHMENT ID: 12627501

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 9 new 
or modified tests.

    {color:red}-1 hadoop1.0{color}.  The patch failed to compile against the 
hadoop 1.0 profile.
    Here is snippet of errors:
    {code}[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) 
on project hbase-client: Compilation failure: Compilation failure:
[ERROR] 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java:[121,12]
 cannot find symbol
[ERROR] symbol  : class HConnectionInternal
[ERROR] location: class org.apache.hadoop.hbase.client.HTable
[ERROR] 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java:[316,43]
 cannot find symbol
[ERROR] symbol  : class HConnectionInternal
--
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) 
on project hbase-client: Compilation failure
        at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:213)
        at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
        at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
        at 
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
        at 
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
--
Caused by: org.apache.maven.plugin.CompilationFailureException: Compilation 
failure
        at 
org.apache.maven.plugin.AbstractCompilerMojo.execute(AbstractCompilerMojo.java:729)
        at org.apache.maven.plugin.CompilerMojo.execute(CompilerMojo.java:128)
        at 
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101)
        at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209)
        ... 19 more{code}

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8617//console

This message is automatically generated.

> HConnection interface is public but is used internally, and contains a bunch 
> of methods
> ---------------------------------------------------------------------------------------
>
>                 Key: HBASE-10479
>                 URL: https://issues.apache.org/jira/browse/HBASE-10479
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>         Attachments: HBASE-10479.patch
>
>
> HConnection has too many methods for a public interface, and some of these 
> should not be public.
> It is used extensively for internal purposes, so we keep adding methods to it 
> that may not make sense for public interface.
> The idea is to create a separate internal interface inheriting HConnection, 
> copy some methods to it and deprecate them on HConnection. New methods for 
> internal use would be added to new interface; the deprecated methods would 
> eventually be removed from public interface.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to