[ 
https://issues.apache.org/jira/browse/HBASE-10479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13895248#comment-13895248
 ] 

Enis Soztutar commented on HBASE-10479:
---------------------------------------

Looks good overall. We will need the isTableAvailable() deprecation I mentioned 
previously. CMI does not extend HCM so we do not have to append "Internal" to 
the method names I think (getConnection() vs getConnectionInternal()). Not that 
important. 

Other than those +1. Nice work. 

> HConnection interface is public but is used internally, and contains a bunch 
> of methods
> ---------------------------------------------------------------------------------------
>
>                 Key: HBASE-10479
>                 URL: https://issues.apache.org/jira/browse/HBASE-10479
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>         Attachments: HBASE-10479.01.patch, HBASE-10479.02.patch, 
> HBASE-10479.03.patch, HBASE-10479.patch
>
>
> HConnection has too many methods for a public interface, and some of these 
> should not be public.
> It is used extensively for internal purposes, so we keep adding methods to it 
> that may not make sense for public interface.
> The idea is to create a separate internal interface inheriting HConnection, 
> copy some methods to it and deprecate them on HConnection. New methods for 
> internal use would be added to new interface; the deprecated methods would 
> eventually be removed from public interface.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to