[
https://issues.apache.org/jira/browse/HBASE-10479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13894990#comment-13894990
]
Enis Soztutar commented on HBASE-10479:
---------------------------------------
bq. This seems valid user method to me.
There are three versions. The method isTableAvailable(TableName) is fine as
user facing. Not the override isTableAvailable(TableName tableName, byte[][]
splitKeys). You can see from the javadoc.
bq. Already deprecated
There are multiple methods named getRegionLocation(). I though one of them was
not deprecated. Fine if you are sure every method that deals with region
locations is deprecated.
bq. There are constants.
I mean please reduce the visibility for the constants if you can. They are
internal afaik.
bq. All the logic will move to ...Internal, and HCM will just call the
internal. You want to do that?
That would be good if we can do it.
> HConnection interface is public but is used internally, and contains a bunch
> of methods
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-10479
> URL: https://issues.apache.org/jira/browse/HBASE-10479
> Project: HBase
> Issue Type: Improvement
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HBASE-10479.01.patch, HBASE-10479.02.patch,
> HBASE-10479.patch
>
>
> HConnection has too many methods for a public interface, and some of these
> should not be public.
> It is used extensively for internal purposes, so we keep adding methods to it
> that may not make sense for public interface.
> The idea is to create a separate internal interface inheriting HConnection,
> copy some methods to it and deprecate them on HConnection. New methods for
> internal use would be added to new interface; the deprecated methods would
> eventually be removed from public interface.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
