[ 
https://issues.apache.org/jira/browse/HBASE-10479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13896207#comment-13896207
 ] 

Hadoop QA commented on HBASE-10479:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12627919/HBASE-10479.final.patch
  against trunk revision .
  ATTACHMENT ID: 12627919

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 30 new 
or modified tests.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8647//console

This message is automatically generated.

> HConnection interface is public but is used internally, and contains a bunch 
> of methods
> ---------------------------------------------------------------------------------------
>
>                 Key: HBASE-10479
>                 URL: https://issues.apache.org/jira/browse/HBASE-10479
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>         Attachments: 45751591.jpg, HBASE-10479.01.patch, 
> HBASE-10479.02.patch, HBASE-10479.03.patch, HBASE-10479.04.patch, 
> HBASE-10479.final.patch, HBASE-10479.patch
>
>
> HConnection has too many methods for a public interface, and some of these 
> should not be public.
> It is used extensively for internal purposes, so we keep adding methods to it 
> that may not make sense for public interface.
> The idea is to create a separate internal interface inheriting HConnection, 
> copy some methods to it and deprecate them on HConnection. New methods for 
> internal use would be added to new interface; the deprecated methods would 
> eventually be removed from public interface.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to