[
https://issues.apache.org/jira/browse/HBASE-10479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13895347#comment-13895347
]
Hadoop QA commented on HBASE-10479:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12627727/HBASE-10479.03.patch
against trunk revision .
ATTACHMENT ID: 12627727
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 27 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ public CreateNamespaceResponse createNamespace(RpcController
controller, CreateNamespaceRequest request) throws ServiceException {
+ public DeleteNamespaceResponse deleteNamespace(RpcController
controller, DeleteNamespaceRequest request) throws ServiceException {
+ public GetNamespaceDescriptorResponse
getNamespaceDescriptor(RpcController controller, GetNamespaceDescriptorRequest
request) throws ServiceException {
+ public ListNamespaceDescriptorsResponse
listNamespaceDescriptors(RpcController controller,
ListNamespaceDescriptorsRequest request) throws ServiceException {
+ public ListTableDescriptorsByNamespaceResponse
listTableDescriptorsByNamespace(RpcController controller,
ListTableDescriptorsByNamespaceRequest request) throws ServiceException {
+
((ConnectionManagerInternal.HConnectionImplementation)abortable).releaseZooKeeperWatcher(this);
+ public MyAsyncProcess(ClusterConnectionInternal hc, Configuration conf,
AtomicInteger nbThreads) {
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8635//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8635//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8635//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8635//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8635//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8635//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8635//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8635//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8635//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8635//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8635//console
This message is automatically generated.
> HConnection interface is public but is used internally, and contains a bunch
> of methods
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-10479
> URL: https://issues.apache.org/jira/browse/HBASE-10479
> Project: HBase
> Issue Type: Improvement
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: 45751591.jpg, HBASE-10479.01.patch,
> HBASE-10479.02.patch, HBASE-10479.03.patch, HBASE-10479.04.patch,
> HBASE-10479.patch
>
>
> HConnection has too many methods for a public interface, and some of these
> should not be public.
> It is used extensively for internal purposes, so we keep adding methods to it
> that may not make sense for public interface.
> The idea is to create a separate internal interface inheriting HConnection,
> copy some methods to it and deprecate them on HConnection. New methods for
> internal use would be added to new interface; the deprecated methods would
> eventually be removed from public interface.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
