[
https://issues.apache.org/jira/browse/HBASE-8963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13933987#comment-13933987
]
Ted Yu commented on HBASE-8963:
-------------------------------
I started reviewing patch v2 and saw patch v3 coming.
Here're my comments based on v2
{code}
+ public static boolean archiveRegion(Configuration conf,FileSystem fs, Path
rootdir, Path tableDir, Path regionDir)
{code}
nit: leave a space following the comma between conf and FileSystem.
For resolveAndArchiveFile(), please add javadoc for parameter conf.
{code}
+ FileStatus currentStatus = fs.getFileStatus(currentFile.getPath());
+
+ if(conf.getBoolean(HFILE_SKIP_ARCHIVE_CONF, false)){
{code}
currentStatus is only used when the condition is true, move its assignment
inside the if block.
> Add configuration option to skip HFile archiving
> ------------------------------------------------
>
> Key: HBASE-8963
> URL: https://issues.apache.org/jira/browse/HBASE-8963
> Project: HBase
> Issue Type: Improvement
> Reporter: Ted Yu
> Assignee: bharath v
> Attachments: HBASE-8963.trunk.v1.patch, HBASE-8963.trunk.v2.patch,
> HBASE-8963.trunk.v3.patch
>
>
> Currently HFileArchiver is always called when a table is dropped.
> A configuration option (either global or per table) should be provided so
> that archiving can be skipped when table is deleted.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
