[
https://issues.apache.org/jira/browse/HBASE-8963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13934305#comment-13934305
]
Hadoop QA commented on HBASE-8963:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12634534/HBASE-8963.trunk.v3.patch
against trunk revision .
ATTACHMENT ID: 12634534
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 5 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the trunk's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ public static boolean archiveRegion(Configuration conf,FileSystem fs,
Path rootdir, Path tableDir, Path regionDir)
+ private static List<File> resolveAndArchive(Configuration conf, FileSystem
fs, Path baseArchiveDir,
+ private static boolean resolveAndArchiveFile(Configuration conf, Path
archiveDir, File currentFile,
+ if(snapshotCleaner.isFileDeletable(currentStatus) &&
fileLinkCleaner.isFileDeletable(currentStatus)){
+ LOG.debug("Attempting to delete file without archiving
:"+currentFile.getPath().getName());
+ LOG.debug("Attempt to delete file
"+currentFile.getPath().getName()+" failed. Moving it to the archive.");
+ // Delete the table, since skiparchive is set unnecessary hfiles
created due to deletes are deleted
+ // Delete a few rows from the original table, for this test we delete
all the rows starting with 'a'.
+ cloneCount = getTableRowCount(new
HTable(TEST_UTIL.getConfiguration(),Bytes.toBytes(TABLENAME3.toString()+".clone")));
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8976//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8976//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8976//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8976//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8976//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8976//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8976//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8976//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8976//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8976//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8976//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8976//console
This message is automatically generated.
> Add configuration option to skip HFile archiving
> ------------------------------------------------
>
> Key: HBASE-8963
> URL: https://issues.apache.org/jira/browse/HBASE-8963
> Project: HBase
> Issue Type: Improvement
> Reporter: Ted Yu
> Assignee: bharath v
> Fix For: 0.99.0
>
> Attachments: HBASE-8963.trunk.v1.patch, HBASE-8963.trunk.v2.patch,
> HBASE-8963.trunk.v3.patch
>
>
> Currently HFileArchiver is always called when a table is dropped.
> A configuration option (either global or per table) should be provided so
> that archiving can be skipped when table is deleted.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
