[ 
https://issues.apache.org/jira/browse/HBASE-8963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13934726#comment-13934726
 ] 

bharath v commented on HBASE-8963:
----------------------------------

[[email protected]] Added v4 as per your comments

[~mbertozzi] I did it for 2 reasons

1) All the archive cleaner plugins (except snapshot and hfilelink cleaner) are 
written assuming the hfile is already in archive . For example 
TimToLiveHFileCleaner which check if the ttl of the hfile "inside the archive" 
directory exceeds the configured timeout. That doesn't need to be run on the 
hfiles which are not yet archived and will always return true. Also any further 
custom implementation of users will expect the store files to be already in 
archive directory and would probably fail if we run the wholeCleanerChain

2) Given this runs only when skipArchive is enabled, users are ok with these 
hfiles getting deleted and won't expect these hfiles to be checked via their 
custom cleaners. 

Are these assumptions valid?

> Add configuration option to skip HFile archiving
> ------------------------------------------------
>
>                 Key: HBASE-8963
>                 URL: https://issues.apache.org/jira/browse/HBASE-8963
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: bharath v
>             Fix For: 0.99.0
>
>         Attachments: HBASE-8963.trunk.v1.patch, HBASE-8963.trunk.v2.patch, 
> HBASE-8963.trunk.v3.patch, HBASE-8963.trunk.v4.patch
>
>
> Currently HFileArchiver is always called when a table is dropped.
> A configuration option (either global or per table) should be provided so 
> that archiving can be skipped when table is deleted.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to