[ 
https://issues.apache.org/jira/browse/HBASE-10847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951630#comment-13951630
 ] 

Gary Helmling commented on HBASE-10847:
---------------------------------------

There is a lot of duplication between 
security/src/test/resources/hbase-site.xml and 
src/test/resources/hbase-site.xml, so my only concern would be changes made to 
one but not the other if they both stay in place.  So +1 to removing the 
security/src/test/resources version and moving the "hbase.rpc.engine" setting 
to src/test/resources.

I also think moving to SecureRpcEngine as the default would make sense, but 
also agree it merits a separate issue for discussion.  There may be impact to 
other project like AsyncHBase?

The rest of the patch looks good to me.

> 0.94: drop non-secure builds, make security the default
> -------------------------------------------------------
>
>                 Key: HBASE-10847
>                 URL: https://issues.apache.org/jira/browse/HBASE-10847
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>             Fix For: 0.94.19
>
>         Attachments: 10847.txt
>
>
> I would like to only create a single 0.94 tarball/release that contains the 
> security code - and drop the non-secure tarballs and releases.
> Let's discuss...



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to