[
https://issues.apache.org/jira/browse/HBASE-10845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967397#comment-13967397
]
Anoop Sam John commented on HBASE-10845:
----------------------------------------
The code changes looks fine.
bq.How does it make sense having a test for memstore size calculation in
TestRegionServerCoprocessorException.testExceptionFromCoprocessorDuringPostBatchMutate
[~stack] failing cp is way by which we can make the rollback to get triggered.
Another way can be making a HLog sync() call to fail. Ted can we put the
test in TestHRegion some way with a custom CP loaded for the region? I guess
this will be bit difficult.
> Memstore snapshot size isn't updated in DefaultMemStore#rollback()
> ------------------------------------------------------------------
>
> Key: HBASE-10845
> URL: https://issues.apache.org/jira/browse/HBASE-10845
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Fix For: 0.99.0, 0.94.19, 0.98.2, 0.96.3
>
> Attachments: 10845-v1.txt, 10845-v2.txt
>
>
> In DefaultMemStore#rollback() :
> {code}
> if (found != null && found.getMvccVersion() == kv.getMvccVersion()) {
> this.snapshot.remove(kv);
> }
> {code}
> this.snapshotSize should be updated in case of rollback.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
