[
https://issues.apache.org/jira/browse/HBASE-10845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967955#comment-13967955
]
Ted Yu commented on HBASE-10845:
--------------------------------
In patch v3, I introduced FaultyHLog in
org.apache.hadoop.hbase.regionserver.wal package so that TestHRegion can get to
FSHLog.
The new test would fail without fix in DefaultMemStore:
{code}
java.lang.AssertionError: flushable size should be zero, but it is 208
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.assertTrue(Assert.java:41)
at
org.apache.hadoop.hbase.regionserver.TestHRegion.testMemstoreSnapshotSize(TestHRegion.java:286)
{code}
> Memstore snapshot size isn't updated in DefaultMemStore#rollback()
> ------------------------------------------------------------------
>
> Key: HBASE-10845
> URL: https://issues.apache.org/jira/browse/HBASE-10845
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Fix For: 0.99.0, 0.94.19, 0.98.2, 0.96.3
>
> Attachments: 10845-v1.txt, 10845-v2.txt, 10845-v3.txt
>
>
> In DefaultMemStore#rollback() :
> {code}
> if (found != null && found.getMvccVersion() == kv.getMvccVersion()) {
> this.snapshot.remove(kv);
> }
> {code}
> this.snapshotSize should be updated in case of rollback.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
