[ 
https://issues.apache.org/jira/browse/HBASE-10845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967727#comment-13967727
 ] 

stack commented on HBASE-10845:
-------------------------------

bq. I tried that approach first - didn't work.

What did you try?

bq. Lars Hofhansl: What do you think of patch v2 ?

You have a -1 on the v2 and two other reviewers ask you change (DD and Anoop) 
it but still you petition another reviewer to entertain v2?  That might not be 
a good course of action.




> Memstore snapshot size isn't updated in DefaultMemStore#rollback()
> ------------------------------------------------------------------
>
>                 Key: HBASE-10845
>                 URL: https://issues.apache.org/jira/browse/HBASE-10845
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>             Fix For: 0.99.0, 0.94.19, 0.98.2, 0.96.3
>
>         Attachments: 10845-v1.txt, 10845-v2.txt
>
>
> In DefaultMemStore#rollback() :
> {code}
>      if (found != null && found.getMvccVersion() == kv.getMvccVersion()) {
>        this.snapshot.remove(kv);
>      }
> {code}
> this.snapshotSize should be updated in case of rollback.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to