[
https://issues.apache.org/jira/browse/HBASE-11007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14001164#comment-14001164
]
Hadoop QA commented on HBASE-11007:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12645436/11007v2.txt
against trunk revision .
ATTACHMENT ID: 12645436
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1
warning messages.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9538//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9538//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9538//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9538//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9538//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9538//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9538//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9538//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9538//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9538//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9538//console
This message is automatically generated.
> BLOCKCACHE in schema descriptor seems not aptly named
> -----------------------------------------------------
>
> Key: HBASE-11007
> URL: https://issues.apache.org/jira/browse/HBASE-11007
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.94.19
> Reporter: Varun Sharma
> Assignee: Varun Sharma
> Priority: Minor
> Fix For: 0.99.0
>
> Attachments: 11007.txt, 11007v2.txt
>
>
> Hi,
> It seems that setting BLOCKCACHE key to false will disable the Data blocks
> from being cached but will continue to cache bloom and index blocks. This
> same property seems to be called cacheDataOnRead inside CacheConfig.
> Should this be called CACHE_DATA_ON_READ instead of BLOCKCACHE similar to the
> other CACHE_DATA_ON_WRITE/CACHE_INDEX_ON_WRITE. We got quite confused and
> ended up adding our own property CACHE_DATA_ON_READ - we also added some unit
> tests for the same.
> What do folks think about this ?
> Thanks
> Varun
--
This message was sent by Atlassian JIRA
(v6.2#6252)
