[ 
https://issues.apache.org/jira/browse/HBASE-11007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14004329#comment-14004329
 ] 

Hudson commented on HBASE-11007:
--------------------------------

SUCCESS: Integrated in HBase-0.98 #309 (See 
[https://builds.apache.org/job/HBase-0.98/309/])
HBASE-11007 BLOCKCACHE in schema descriptor seems not aptly named; REVERT 
(stack: rev 1595942)
* 
/hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java
* 
/hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java
* 
/hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheStats.java
* 
/hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestForceCacheImportantBlocks.java
HBASE-11007 BLOCKCACHE in schema descriptor seems not aptly named (stack: rev 
1595939)
* 
/hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java
* 
/hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java
* 
/hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheStats.java
* 
/hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestForceCacheImportantBlocks.java


> BLOCKCACHE in schema descriptor seems not aptly named
> -----------------------------------------------------
>
>                 Key: HBASE-11007
>                 URL: https://issues.apache.org/jira/browse/HBASE-11007
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.94.19
>            Reporter: Varun Sharma
>            Assignee: Varun Sharma
>            Priority: Minor
>             Fix For: 0.99.0
>
>         Attachments: 11007.txt, 11007v2.txt
>
>
> Hi,
> It seems that setting BLOCKCACHE key to false will disable the Data blocks 
> from being cached but will continue to cache bloom and index blocks. This 
> same property seems to be called cacheDataOnRead inside CacheConfig.
> Should this be called CACHE_DATA_ON_READ instead of BLOCKCACHE similar to the 
> other CACHE_DATA_ON_WRITE/CACHE_INDEX_ON_WRITE. We got quite confused and 
> ended up adding our own property CACHE_DATA_ON_READ - we also added some unit 
> tests for the same.
> What do folks think about this ?
> Thanks
> Varun



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to