[ 
https://issues.apache.org/jira/browse/HBASE-4117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086126#comment-13086126
 ] 

stack commented on HBASE-4117:
------------------------------

@Andrew I appreciate your showing up in your architect hat flashing the red 
card.  Please stay on the prowl and flag the violations.

In this case, on review, I think we are talking honest logging (logging already 
has a system that facilitates redirection and feeding events to other than 
files that live under HBASE_LOG_DIR -- which reminds me, I need to go back to 
Riley and make sure that these events CAN be directed to other than the .log 
file cleanly).  As Riley says, these logs at an extreme will likely make most 
sense if shown in context amidst the logging of what else was going on on the 
server.

The patch also includes nice refactoring of base classes -- Scan, Get, etc. -- 
to make it so they can dump out a self-description (either a 
fingerprint/synopsis, or a full catalog of the payload being carried) in text 
or json that looks like it can be passed to whatever asks for the info (log or 
metrics or...)

We are still missing the general theory on how to pass hbase emissions but I 
think this patch helps move us closer to a general system much more than it 
adds distraction.

> Slow Query Log
> --------------
>
>                 Key: HBASE-4117
>                 URL: https://issues.apache.org/jira/browse/HBASE-4117
>             Project: HBase
>          Issue Type: New Feature
>          Components: ipc
>            Reporter: Riley Patterson
>            Assignee: Riley Patterson
>            Priority: Minor
>              Labels: client, ipc
>         Attachments: HBASE-4117.patch
>
>
> Produce log messages for slow queries. The RPC server will decide what is 
> slow based on a configurable "warn response time" parameter. Queries 
> designated as slow will then output a "response too slow" message followed by 
> a fingerprint of the query, and a summary limited in size by another 
> configurable parameter (to limit log spamming).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to