[
https://issues.apache.org/jira/browse/HBASE-4117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089146#comment-13089146
]
[email protected] commented on HBASE-4117:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1621/
-----------------------------------------------------------
(Updated 2011-08-22 23:25:12.626245)
Review request for hbase.
Changes
-------
Addressed stack's comments from last week, cleaned up code, standardized many
fields in the JSON output.
Summary
-------
Exposes JSON-parseable fingerprint and details for queries that take longer
than a configurable threshold time. The exposure is currently to the main
regionserver log, along with a (operationTooSlow) tag which allows it to be
grepped out and easily aggregated and/or monitored in administrator scripts.
The patch also provides a standard way to extract fingerprint and detail
information of interest by requiring each "Operation" to provide a fingerprint
map and a details map, which will be a superset of the fingerprint.
This addresses bug HBASE-4117.
https://issues.apache.org/jira/browse/HBASE-4117
Diffs
-----
/src/main/java/org/apache/hadoop/hbase/KeyValue.java 1160468
/src/main/java/org/apache/hadoop/hbase/client/Delete.java 1160468
/src/main/java/org/apache/hadoop/hbase/client/Get.java 1160468
/src/main/java/org/apache/hadoop/hbase/client/MultiAction.java 1160468
/src/main/java/org/apache/hadoop/hbase/client/MultiPut.java 1160468
/src/main/java/org/apache/hadoop/hbase/client/Operation.java PRE-CREATION
/src/main/java/org/apache/hadoop/hbase/client/Put.java 1160468
/src/main/java/org/apache/hadoop/hbase/client/Scan.java 1160468
/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java 1160468
/src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java 1160468
/src/test/java/org/apache/hadoop/hbase/client/TestOperation.java PRE-CREATION
Diff: https://reviews.apache.org/r/1621/diff
Testing
-------
Monitored get and put latency with and without the patch using reasonable
hbase.ipc.warn.response.time settings (1000ms, 2000ms). Performance was not
noticeably impacted.
Thanks,
Riley
> Slow Query Log
> --------------
>
> Key: HBASE-4117
> URL: https://issues.apache.org/jira/browse/HBASE-4117
> Project: HBase
> Issue Type: New Feature
> Components: ipc
> Reporter: Riley Patterson
> Assignee: Riley Patterson
> Priority: Minor
> Labels: client, ipc
> Attachments: HBASE-4117.patch
>
>
> Produce log messages for slow queries. The RPC server will decide what is
> slow based on a configurable "warn response time" parameter. Queries
> designated as slow will then output a "response too slow" message followed by
> a fingerprint of the query, and a summary limited in size by another
> configurable parameter (to limit log spamming).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
