[
https://issues.apache.org/jira/browse/HBASE-4117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13092185#comment-13092185
]
[email protected] commented on HBASE-4117:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1621/#review1669
-----------------------------------------------------------
Ship it!
/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java
<https://reviews.apache.org/r/1621/#comment3771>
Why remove this stuff Riley? Seems useful? Or, looks like you moved it.
What you thinking? Move it out of the generic into the specific implementation
engine?
/src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java
<https://reviews.apache.org/r/1621/#comment3772>
nice
Doing check for both too large and too slow
I suppose this answers my previous question.
- Michael
On 2011-08-26 04:00:49, Riley Patterson wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1621/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-08-26 04:00:49)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Exposes JSON-parseable fingerprint and details for queries that take
longer than a configurable threshold time. The exposure is currently to the
main regionserver log, along with a (operationTooSlow) tag which allows it to
be grepped out and easily aggregated and/or monitored in administrator scripts.
bq.
bq. The patch also provides a standard way to extract fingerprint and detail
information of interest by requiring each "Operation" to provide a fingerprint
map and a details map, which will be a superset of the fingerprint.
bq.
bq.
bq. This addresses bug HBASE-4117.
bq. https://issues.apache.org/jira/browse/HBASE-4117
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /src/main/java/org/apache/hadoop/hbase/KeyValue.java 1161979
bq. /src/main/java/org/apache/hadoop/hbase/client/Delete.java 1161979
bq. /src/main/java/org/apache/hadoop/hbase/client/Get.java 1161979
bq. /src/main/java/org/apache/hadoop/hbase/client/MultiAction.java 1161979
bq. /src/main/java/org/apache/hadoop/hbase/client/MultiPut.java 1161979
bq. /src/main/java/org/apache/hadoop/hbase/client/Operation.java
PRE-CREATION
bq. /src/main/java/org/apache/hadoop/hbase/client/Put.java 1161979
bq. /src/main/java/org/apache/hadoop/hbase/client/Scan.java 1161979
bq. /src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java 1161979
bq. /src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java
1161979
bq. /src/test/java/org/apache/hadoop/hbase/client/TestOperation.java
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/1621/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Monitored get and put latency with and without the patch using reasonable
hbase.ipc.warn.response.time settings (1000ms, 2000ms). Performance was not
noticeably impacted.
bq.
bq.
bq. Thanks,
bq.
bq. Riley
bq.
bq.
> Slow Query Log
> --------------
>
> Key: HBASE-4117
> URL: https://issues.apache.org/jira/browse/HBASE-4117
> Project: HBase
> Issue Type: New Feature
> Components: ipc
> Reporter: Riley Patterson
> Assignee: Riley Patterson
> Priority: Minor
> Labels: client, ipc
> Attachments: HBASE-4117-v2.patch, HBASE-4117-v3.patch,
> HBASE-4117.patch
>
>
> Produce log messages for slow queries. The RPC server will decide what is
> slow based on a configurable "warn response time" parameter. Queries
> designated as slow will then output a "response too slow" message followed by
> a fingerprint of the query, and a summary limited in size by another
> configurable parameter (to limit log spamming).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
