[
https://issues.apache.org/jira/browse/HBASE-10674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083061#comment-14083061
]
Alex Newman commented on HBASE-10674:
-------------------------------------
OK I have no commit bit, that being said.....
What's going on here, can we make it into a function? This has gotten pretty
hairy
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
@@ -2949,6 +2949,7 @@ public class HBaseFsck extends Configured {
} else {
m = new MetaEntry(hri, sn, ts, null, null);
}
HbckInfo previous = regionInfoMap.get(hri.getEncodedName());
if (previous == null) {
regionInfoMap.put(hri.getEncodedName(), new HbckInfo(m));
....
/TODO What does first online hri mean? Maybe a javadoc?
return FSUtils.getTableName(tableDir);
} else {
// return the info from the first online hri
for (OnlineEntry e : deployedEntries) {
return e.hri.getTable();
}
This is weirdly formatted. Maybe run an autoformat
++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsckRepair.ja
@@ -186,12 +186,14 @@ public class HBaseFsckRepair {
* Puts the specified HRegionInfo into META with replica related columns
*/
public static void fixMetaHoleOnlineAndAddReplicas(Configuration conf,
- HRegionInfo hri, Collection<ServerName> servers, int numReplicas) throws
> HBCK should be updated to do replica related checks
> ---------------------------------------------------
>
> Key: HBASE-10674
> URL: https://issues.apache.org/jira/browse/HBASE-10674
> Project: HBase
> Issue Type: Sub-task
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Attachments: 10674-1.2.txt, 10674-1.txt
>
>
> HBCK should be updated to have a check for whether the replicas are assigned
> to the right machines (default and non-default replicas ideally should not be
> in the same server if there is more than one server in the cluster and such
> scenarios). [~jmhsieh] suggested this in HBASE-10362.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
