[
https://issues.apache.org/jira/browse/HBASE-10674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083105#comment-14083105
]
Nick Dimiduk commented on HBASE-10674:
--------------------------------------
{noformat}
+ Result r = meta.get(get);
+ RegionLocations rl = MetaTableAccessor.getRegionLocations(r);
+ if (rl == null) return;
{noformat}
Should this be an error instead of silently returning?
{noformat}
+ for (HRegionLocation h : rl.getRegionLocations()) {
+ if (h == null || h.getRegionInfo() == null) {
+ continue;
+ }
{noformat}
And this should be an error as well, especially if h.getRegionInfo() is null?
Nice tests. Just when I was thinking "what about this case?" I find a test for
it.
Questions aside, LGTM, +1.
> HBCK should be updated to do replica related checks
> ---------------------------------------------------
>
> Key: HBASE-10674
> URL: https://issues.apache.org/jira/browse/HBASE-10674
> Project: HBase
> Issue Type: Sub-task
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Attachments: 10674-1.2.txt, 10674-1.txt
>
>
> HBCK should be updated to have a check for whether the replicas are assigned
> to the right machines (default and non-default replicas ideally should not be
> in the same server if there is more than one server in the cluster and such
> scenarios). [~jmhsieh] suggested this in HBASE-10362.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
