[ 
https://issues.apache.org/jira/browse/HBASE-10674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083066#comment-14083066
 ] 

Alex Newman commented on HBASE-10674:
-------------------------------------

Woops accidently hit add

....
   if (numReplicas > 1) {
       Random r = new Random();

Shouldn't this be?
-      ServerName[] serversArr = servers.toArray(new ServerName[0]);
+      ServerName[] serversArr = servers.toArray(new ServerName[servers.size()])

You have a spare todo around
---- 
a/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
+++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
@@ -301,6 +301,7 @@ public class TestHBaseFsck {
    * @param metaRow  if true remove region's row from META
    * @param hdfs if true remove region's dir in HDFS
    * @param regionInfoOnly if true remove a region dir's .regioninfo file
    * @param replicaId TODO
    */
   private void deleteRegion(Configuration conf, final HTableDescriptor htd,


> HBCK should be updated to do replica related checks
> ---------------------------------------------------
>
>                 Key: HBASE-10674
>                 URL: https://issues.apache.org/jira/browse/HBASE-10674
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>         Attachments: 10674-1.2.txt, 10674-1.txt
>
>
> HBCK should be updated to have a check for whether the replicas are assigned 
> to the right machines (default and non-default replicas ideally should not be 
> in the same server if there is more than one server in the cluster and such 
> scenarios). [~jmhsieh] suggested this in HBASE-10362.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to