[
https://issues.apache.org/jira/browse/HBASE-11699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14098769#comment-14098769
]
Hadoop QA commented on HBASE-11699:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12661994/HBASE_11699_v3.patch
against trunk revision .
ATTACHMENT ID: 12661994
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 3
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ * <code>rpc
GetExcludedRegionsServers(.GetExcludedRegionsServersRequest) returns
(.GetExcludedRegionsServersResponse);</code>
+ * <code>rpc GetIncludedRegionServers(.GetIncludedRegionServersRequest)
returns (.GetIncludedRegionServersResponse);</code>
+ * <code>rpc
AddRegionServerToExclusionList(.AddRegionServerToExclusionListRequest) returns
(.AddRegionServerToExclusionListResponse);</code>
+ * <code>rpc
AddRegionServerToInclusionList(.AddRegionServerToInclusionListRequest) returns
(.AddRegionServerToInclusionListResponse);</code>
+ * <code>rpc GetExcludedRegionsServers(.GetExcludedRegionsServersRequest)
returns (.GetExcludedRegionsServersResponse);</code>
+ * <code>rpc GetIncludedRegionServers(.GetIncludedRegionServersRequest)
returns (.GetIncludedRegionServersResponse);</code>
+ * <code>rpc
AddRegionServerToExclusionList(.AddRegionServerToExclusionListRequest) returns
(.AddRegionServerToExclusionListResponse);</code>
+ * <code>rpc
AddRegionServerToInclusionList(.AddRegionServerToInclusionListRequest) returns
(.AddRegionServerToInclusionListResponse);</code>
+ if
(!cluster.getMaster().getServerManager().getOnlineServersList().contains(serverName))
break;
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/10458//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10458//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10458//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10458//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10458//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10458//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10458//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10458//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10458//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10458//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/10458//console
This message is automatically generated.
> Region servers exclusion list to HMaster.
> -----------------------------------------
>
> Key: HBASE-11699
> URL: https://issues.apache.org/jira/browse/HBASE-11699
> Project: HBase
> Issue Type: New Feature
> Components: Admin, Client, regionserver, Zookeeper
> Affects Versions: 0.98.3
> Reporter: Gomathivinayagam Muthuvinayagam
> Priority: Minor
> Labels: patch
> Fix For: 0.99.0, 2.0.0, 0.98.6
>
> Attachments: HBASE_11699.patch, HBASE_11699_v1.patch,
> HBASE_11699_v2.patch, HBASE_11699_v3.patch
>
> Original Estimate: 96h
> Remaining Estimate: 96h
>
> Currently HBase does not support adding set of region servers to be in the
> exclusion list. So that administrators can prevent accidental startups of
> some region servers to join the cluster. There was initially some work done,
> and it is available in https://issues.apache.org/jira/browse/HBASE-3833. It
> was not done after that.
> I am planning to contribute it as a patch, and I would like to do some
> improvements as well. Instead of storing the exclusion entries on a file, I
> am planning to store it on zookeeper. Can anyone suggest thoughts on this?
--
This message was sent by Atlassian JIRA
(v6.2#6252)
