[
https://issues.apache.org/jira/browse/HBASE-12090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14150197#comment-14150197
]
stack commented on HBASE-12090:
-------------------------------
bq. I need to find explanation why patched version does not show significant
improvement in a GET - Narrow Table test.
Less compares per result returned?
Otherwise patch looks good on a skim. This stuff is a little unsettling if
(UnsafeComparer.littleEndian) { but seems fine on a read through. Your thinking
is that TestBytes is coverage enough for this new code [~vrodionov]? They do
tests that go in and out of bytes. You don't think we need a test that does
unsafe and safe and then compares result?
Deferring to Lars's testing but this looks good to me.
> Bytes: more Unsafe, more Faster
> --------------------------------
>
> Key: HBASE-12090
> URL: https://issues.apache.org/jira/browse/HBASE-12090
> Project: HBase
> Issue Type: Improvement
> Components: Performance
> Affects Versions: 0.94.23, 0.98.6
> Reporter: Vladimir Rodionov
> Assignee: Vladimir Rodionov
> Fix For: 2.0.0, 0.98.7, 0.94.24, 0.99.1
>
> Attachments: 12090-v1.1.txt, HBASE-12090.2.patch, HBASE-12090.patch
>
>
> Additional optimizations to *org.apache.hadoop.hbase.util.Bytes*:
> * New version of compareTo method.
> * New versions for primitive converters : putXXX/toXXX.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
