[
https://issues.apache.org/jira/browse/HBASE-12090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14150367#comment-14150367
]
Lars Hofhansl commented on HBASE-12090:
---------------------------------------
I can confirm the scan numbers (tested with a table with 5 cols, 1 version).
Nice!
bq. Your thinking is that TestBytes is coverage enough for this new code
Vladimir Rodionov?
I think this code is exercised during normal operations in the tests.
Looked through the patch looks good to me. The only part I am little but fuzzy
on the compareTo change, but I can't see anything wrong in that.
+1
[~apurtell], I assume you're cool with this in 0.98. It's nice speed
improvement. Will commit too all branches by tomorrow morning unless I hear
objections.
> Bytes: more Unsafe, more Faster
> --------------------------------
>
> Key: HBASE-12090
> URL: https://issues.apache.org/jira/browse/HBASE-12090
> Project: HBase
> Issue Type: Improvement
> Components: Performance
> Affects Versions: 0.94.23, 0.98.6
> Reporter: Vladimir Rodionov
> Assignee: Vladimir Rodionov
> Fix For: 2.0.0, 0.98.7, 0.94.24, 0.99.1
>
> Attachments: 12090-v1.1.txt, HBASE-12090.2.patch, HBASE-12090.patch
>
>
> Additional optimizations to *org.apache.hadoop.hbase.util.Bytes*:
> * New version of compareTo method.
> * New versions for primitive converters : putXXX/toXXX.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
