[
https://issues.apache.org/jira/browse/HBASE-4321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096051#comment-13096051
]
stack commented on HBASE-4321:
------------------------------
So far, excellent.
Its a bit odd methinks that the public signature of the RegionSplitCalculator
class takes extensions of a generic that is an abstract interior class. Do you
think the interior class has enough heft to live outside of
RegionSplitCalculator?
What are the start/end keys passed here? Are they .META. rows or the start/end
rows from regions? If the former, the comparator as is won't work -- Bytes
only (see the meta comparators in KeyValue) -- else what if the problem in
.META. spans tables? (It doesn't look easy getting other comparators into the
code as written)
The dump function in the test looks great.
Good stuff Jon.
> Add more comprehensive region split calculator
> ----------------------------------------------
>
> Key: HBASE-4321
> URL: https://issues.apache.org/jira/browse/HBASE-4321
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments:
> 0001-HBASE-4321-Add-more-comprehensive-region-split-calcu.patch
>
>
> Hbck currently scans through meta one entry at a time, only keeping a
> reference to the previous meta entry. This is insufficient for capturing all
> the possible problems in meta and needs something more to properly identify
> holes, overlaps, duplicate start keys, and otherwise invalid meta entries.
> Ideally, this calculator could also be used online interrogating an existing
> meta (HBASE-4058), and also used to generate a completely new meta offline
> just from regioninfo and in hdfs (HBASE-3505).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
