[
https://issues.apache.org/jira/browse/HBASE-4321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096084#comment-13096084
]
Jonathan Hsieh commented on HBASE-4321:
---------------------------------------
I think the main concern is that this is a public static abstract. I can pull
the Range out and make it a separate file. Would it makes sense to pull this
out in to a subpackage? o.a.h.h.util.splits? o.a.h.h.util.hbck?
I'm not clear if the generic a concern. Is it?
The start keys and end keys can be whatever, I wrote it generically to make
testing easy and straight forward.
In a follow on patch, the start/end keys are the actual start and end keys of a
region -- not the .META. rows. Basically, I subclass and wrap hbckinfos and
use hbckinfo.metaData.getStartKey() and hbckinfo.metaData.getEndKey() as the
range's getStartKey/getEndKeys.
I know Todd wants to do an offline meta table rebuild that just looks at
.regioninfo's on HDFS. So for that case, the Range would subclass wrap an
HRegionInfo and use hri.getStartKey(), and hri.getEndKey().
> Add more comprehensive region split calculator
> ----------------------------------------------
>
> Key: HBASE-4321
> URL: https://issues.apache.org/jira/browse/HBASE-4321
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments:
> 0001-HBASE-4321-Add-more-comprehensive-region-split-calcu.patch
>
>
> Hbck currently scans through meta one entry at a time, only keeping a
> reference to the previous meta entry. This is insufficient for capturing all
> the possible problems in meta and needs something more to properly identify
> holes, overlaps, duplicate start keys, and otherwise invalid meta entries.
> Ideally, this calculator could also be used online interrogating an existing
> meta (HBASE-4058), and also used to generate a completely new meta offline
> just from regioninfo and in hdfs (HBASE-3505).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
