[ 
https://issues.apache.org/jira/browse/HBASE-4321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13102381#comment-13102381
 ] 

[email protected] commented on HBASE-4321:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1703/
-----------------------------------------------------------

(Updated 2011-09-11 23:54:04.559005)


Review request for hbase, Todd Lipcon and Michael Stack.


Changes
-------

Address nits and comments.  Applies and passes on 0.90 and trunk.


Summary
-------

This is the core region split calculator.  It provides a sorted set of region 
split points, and a "coverage" multimap.  This is enough information to 
properly determine dupe start keys, all the different kinds of overlap, as well 
as holes.


This addresses bug hbase-4321.
    https://issues.apache.org/jira/browse/hbase-4321


Diffs (updated)
-----

  src/main/java/org/apache/hadoop/hbase/util/KeyRange.java PRE-CREATION 
  src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java 
PRE-CREATION 
  src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/1703/diff


Testing
-------

Unit tests just checks algorithm, no dependencies on HBase yet.


Thanks,

jmhsieh



> Add more comprehensive region split calculator
> ----------------------------------------------
>
>                 Key: HBASE-4321
>                 URL: https://issues.apache.org/jira/browse/HBASE-4321
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.4
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>         Attachments: 
> 0001-HBASE-4321-Add-more-comprehensive-region-split-calcu.patch, 
> hbase-4321.diff
>
>
> Hbck currently scans through meta one entry at a time, only keeping a 
> reference to the previous meta entry.  This is insufficient for capturing all 
> the possible problems in meta and needs something more to properly identify 
> holes, overlaps, duplicate start keys, and otherwise invalid meta entries.
> Ideally, this calculator could also be used online interrogating an existing 
> meta (HBASE-4058), and also used to generate a completely new meta offline 
> just from regioninfo and in hdfs (HBASE-3505). 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to