[
https://issues.apache.org/jira/browse/HBASE-12490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14224873#comment-14224873
]
Hadoop QA commented on HBASE-12490:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12683600/HBASE-12490C.patch
against master branch at commit e6b4300756b7f09a31ba35cb3baf41d294ed6e14.
ATTACHMENT ID: 12683600
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 45 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11828//console
This message is automatically generated.
> Replace uses of setAutoFlush(boolean, boolean)
> ----------------------------------------------
>
> Key: HBASE-12490
> URL: https://issues.apache.org/jira/browse/HBASE-12490
> Project: HBase
> Issue Type: Bug
> Affects Versions: 2.0.0, 0.99.2
> Reporter: Solomon Duskis
> Assignee: Solomon Duskis
> Attachments: HBASE-12490.patch, HBASE-12490B.patch,
> HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490C.patch
>
>
> The various uses of setAutoFlush() seem to need some tlc. There's a note in
> HTableInterface: "@deprecated in 0.99 since setting clearBufferOnFail is
> deprecated. Use setAutoFlushTo(boolean) instead." It would be ideal to
> change all internal uses of setAutoFlush(boolean, boolean) to use
> setAutoFlushTo, if possible.
> HTable.setAutoFlush(boolean, boolean) is used in a handful of places.
> setAutoFlush(false, false) has the same results as
> HTable.setAutoFlush(false). Calling HTable.setAutoFlush(false, true) has the
> same affect as Table.setAutoFlushTo(false), assuming
> HTable.setAutoFlush(false) was not called previously (by default, the second
> parameter, clearBufferOnFail, is true and should remain true according to the
> comments).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
