[
https://issues.apache.org/jira/browse/HBASE-12490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14224939#comment-14224939
]
Nicolas Liochon commented on HBASE-12490:
-----------------------------------------
Yeah, I saw it but I was ok with you answer so I didn't comment :-)
Let's try to decide in this jira (Nick should see it).
My point of view is:
- we should not change the meaning of setAutoFlush(boolean), as it would be
confusing during the upgrade (i.e. someone upgrading from .098 to 1.0 would
have its code compiling but with a hidden behavior change)
- we should not use setAutoFlush(boolean), may be we should remove it in 1.0.
This because of the confusion around it's a setter-like that is not a setter.
- I don't think that we need to keep clearBufferOnFail (i.e. we could remove
it in 1.0), but may be I'm wrong here. If we do that then we can keep
setAutoFlush(boolean), it will become a real setter (and then the points above
are not an issue anymore.
> Replace uses of setAutoFlush(boolean, boolean)
> ----------------------------------------------
>
> Key: HBASE-12490
> URL: https://issues.apache.org/jira/browse/HBASE-12490
> Project: HBase
> Issue Type: Bug
> Affects Versions: 2.0.0, 0.99.2
> Reporter: Solomon Duskis
> Assignee: Solomon Duskis
> Attachments: HBASE-12490.patch, HBASE-12490B.patch,
> HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490C.patch
>
>
> The various uses of setAutoFlush() seem to need some tlc. There's a note in
> HTableInterface: "@deprecated in 0.99 since setting clearBufferOnFail is
> deprecated. Use setAutoFlushTo(boolean) instead." It would be ideal to
> change all internal uses of setAutoFlush(boolean, boolean) to use
> setAutoFlushTo, if possible.
> HTable.setAutoFlush(boolean, boolean) is used in a handful of places.
> setAutoFlush(false, false) has the same results as
> HTable.setAutoFlush(false). Calling HTable.setAutoFlush(false, true) has the
> same affect as Table.setAutoFlushTo(false), assuming
> HTable.setAutoFlush(false) was not called previously (by default, the second
> parameter, clearBufferOnFail, is true and should remain true according to the
> comments).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
