[ 
https://issues.apache.org/jira/browse/HBASE-12012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14238123#comment-14238123
 ] 

Nick Dimiduk commented on HBASE-12012:
--------------------------------------

No test changes?

I like the Cancellable interface too.

Separate interface? Can we not push this feature down into all 
{{RetryingCallables}}?

{noformat}
[email protected]
+interface CancellableCallable<T> extends RetryingCallable<T> {
+  public void startCancel();
+}
{noformat}

Down in ScannerCallableWithReplicas, should the change to {{canceled}} and call 
to {{caller.cancel()}} be synchronized?

{noformat}
+    @Override
+    public void startCancel() {
+      canceled = true;
+      caller.cancel();
+      if (callable.getController() != null) {
+        callable.getController().startCancel();
+      }
{noformat}

> Improve cancellation for the scan RPCs
> --------------------------------------
>
>                 Key: HBASE-12012
>                 URL: https://issues.apache.org/jira/browse/HBASE-12012
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 1.0.0, 2.0.0
>
>         Attachments: 12012-1.txt, 12012-2.txt, 12012-3.txt
>
>
> Similar to HBASE-11564 but for scans.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to