[
https://issues.apache.org/jira/browse/HBASE-12012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14250931#comment-14250931
]
Devaraj Das commented on HBASE-12012:
-------------------------------------
Thanks for the review, [~ndimiduk]. This patch mostly is a refactor and has
been tested manually. Not easy to write unit tests for this. On your specific
comments:
bq. Separate interface? Can we not push this feature down into all
RetryingCallables?
This makes sense for the replica callables.. So it's done for those only..
bq. Down in ScannerCallableWithReplicas, should the change to canceled and call
to caller.cancel() be synchronized?
I don't think we need to add synchronized here. Can you see a reason for this?
'canceled' is volatile btw.
> Improve cancellation for the scan RPCs
> --------------------------------------
>
> Key: HBASE-12012
> URL: https://issues.apache.org/jira/browse/HBASE-12012
> Project: HBase
> Issue Type: Sub-task
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 1.0.0, 2.0.0
>
> Attachments: 12012-1.txt, 12012-2.txt, 12012-3.txt
>
>
> Similar to HBASE-11564 but for scans.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
