[
https://issues.apache.org/jira/browse/HBASE-12012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14254025#comment-14254025
]
Devaraj Das commented on HBASE-12012:
-------------------------------------
bq. You say it is 'okay' in your opinion. Want to make an argument why?
As I said, it's my opinion. You have a different opinion. That's all. Given
that I already have what I have, I don't see a strong reason for changing that
to use decoration.
bq. isCanceled should have two els in it
Smile. This is something I considered as well. Trust me. It seems in America
this spelling is fine. http://dictionary.reference.com/browse/canceled The Brit
version has two 'l'. I preferred the single 'l' for obvious reasons. If you
insist I can change it to the Brit spelling. Let me do that.
bq. You are not implying that because the Interface is private, we can be lax
about what is committed?
No. I am trying to work with you to get something that we both are comfortable
with. If you absolutely want me to change this to a Decoration, let me know.
bq. What is 'startCancel'? Why not just 'cancel'?
Sure. The startCancel was already there and I kept the same name (grep for
startCancel in the patch and you will know what I mean)
bq. It is necessary undoing the private here?
Let me check on this.
bq. Rest of the patch looks good. Any chance of a test for new functionality?
Thanks. This patch has been tested manually. It mainly brings the Scan
cancellation at par with how Get cancellation works - not much net new
functionality.
bq. An argument you could make for your new Interface and its 'odd' method
namings is that RpcController... but it unorthodox and makes your Interface a
little odd to read (see above examples))
And I try to explain above some reasons. Hope it makes more sense now.
> Improve cancellation for the scan RPCs
> --------------------------------------
>
> Key: HBASE-12012
> URL: https://issues.apache.org/jira/browse/HBASE-12012
> Project: HBase
> Issue Type: Sub-task
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 2.0.0, 1.1.0
>
> Attachments: 12012-1.txt, 12012-2.txt, 12012-3.txt, 12012-4.txt
>
>
> Similar to HBASE-11564 but for scans.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
