[
https://issues.apache.org/jira/browse/HBASE-12740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14255986#comment-14255986
]
Dima Spivak commented on HBASE-12740:
-------------------------------------
Thanks so much for taking this on, Jurriaan (especially taking a good step in
moving to the new non H- objects). Looks lovely, with some comments:
- Since I see a lot of 7s and factors of 7, might it be worth defining a
constant at the top and then just using throughout so that if this needs tuning
in the future, it can be changed in one place?
- HBaseTestingUtility has its own "deleteTable" method. Might it be worth
plugging those in here instead of having this alternative implementation around?
- What was the rationale for having setupTableWithRegionReplica return an
HTable instance (instead of a plain Table)?
> Improve performance of TestHBaseFsck
> ------------------------------------
>
> Key: HBASE-12740
> URL: https://issues.apache.org/jira/browse/HBASE-12740
> Project: HBase
> Issue Type: Bug
> Components: util
> Reporter: Jurriaan Mous
> Assignee: Jurriaan Mous
> Attachments: HBASE-12740.patch
>
>
> TestHBaseFsck performs poor on my machine. It crashes because the threads
> reach the 2000 thread limit on my machine. Looking at the code a lot of
> optimization is possible and some API calls are used wrong. A lot of Admin
> instances are created and never closed, lots of Tables are not closed,
> ThreadPoolExecutors are not shut down and an unlimited thread pool which does
> not recycle threads.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
