[ 
https://issues.apache.org/jira/browse/HBASE-12740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14261442#comment-14261442
 ] 

Hadoop QA commented on HBASE-12740:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12689556/HBASE-12740-v4.patch
  against master branch at commit c6002ccd3873f3950df50bef7f4ac4c5760d595f.
  ATTACHMENT ID: 12689556

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 11 new 
or modified tests.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12265//console

This message is automatically generated.

> Improve performance of TestHBaseFsck
> ------------------------------------
>
>                 Key: HBASE-12740
>                 URL: https://issues.apache.org/jira/browse/HBASE-12740
>             Project: HBase
>          Issue Type: Bug
>          Components: util
>            Reporter: Jurriaan Mous
>            Assignee: Jurriaan Mous
>         Attachments: HBASE-12740-v1.patch, HBASE-12740-v2.patch, 
> HBASE-12740-v3.patch, HBASE-12740-v4.patch, HBASE-12740.patch, 
> PROFILE_after_patch.png, PROFILE_before_patch_test_fails.png
>
>
> TestHBaseFsck performs poor on my machine. It crashes because the threads 
> reach the 2000 thread limit on my machine. Looking at the code a lot of 
> optimization is possible and some API calls are used wrong. A lot of Admin 
> instances are created and never closed, lots of Tables are not closed, 
> ThreadPoolExecutors are not shut down and an unlimited thread pool which does 
> not recycle threads.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to