[ 
https://issues.apache.org/jira/browse/HBASE-12740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14260480#comment-14260480
 ] 

Dima Spivak commented on HBASE-12740:
-------------------------------------

Hey [~jurmous],

Sorry for the delay in getting back to this; busy time with the holidays. I 
finally had a chance to apply your patch to master (thanks again for rebasing 
for me) and, having run it a half dozen times, I can't seem to reproduce the 
speed-up you're seeing on TestHBaseFsck. Running Maven 3.0.4 and Java 1.7u67, I 
get averaged runtimes of about 277 s before the patch is applied and 287 s 
afterwards. Am I missing something?

> Improve performance of TestHBaseFsck
> ------------------------------------
>
>                 Key: HBASE-12740
>                 URL: https://issues.apache.org/jira/browse/HBASE-12740
>             Project: HBase
>          Issue Type: Bug
>          Components: util
>            Reporter: Jurriaan Mous
>            Assignee: Jurriaan Mous
>         Attachments: HBASE-12740-v1.patch, HBASE-12740-v2.patch, 
> HBASE-12740-v3.patch, HBASE-12740.patch
>
>
> TestHBaseFsck performs poor on my machine. It crashes because the threads 
> reach the 2000 thread limit on my machine. Looking at the code a lot of 
> optimization is possible and some API calls are used wrong. A lot of Admin 
> instances are created and never closed, lots of Tables are not closed, 
> ThreadPoolExecutors are not shut down and an unlimited thread pool which does 
> not recycle threads.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to