[ 
https://issues.apache.org/jira/browse/HBASE-12867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14285271#comment-14285271
 ] 

Enis Soztutar commented on HBASE-12867:
---------------------------------------

bq. but for 1.x and 0.98.x there should be a way to add a custom replication 
endpoint peer from the shell and still be able to use the add_peer command how 
it has been used in the past
Agreed. BC is needed. If adding {{ENDPOINT_CLASSNAME}} or something similar is 
doable in jruby, I think that is acceptable. 

> Shell does not support custom replication endpoint specification
> ----------------------------------------------------------------
>
>                 Key: HBASE-12867
>                 URL: https://issues.apache.org/jira/browse/HBASE-12867
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Andrew Purtell
>            Assignee: Jingcheng Du
>              Labels: beginner, beginners
>             Fix For: 1.0.0, 2.0.0, 1.1.0, 0.98.11
>
>         Attachments: HBASE-12867.patch
>
>
> On HBASE-12254 and also at 
> https://github.com/risdenk/hbase-custom-replication-endpoint-example 
> [~risdenk] made the following observations and suggestions regarding custom 
> replication endpoints that I think are a reasonable blueprint for improvement:
> {quote}
> I was trying out the pluggable replication endpoint feature and found the 
> following:
> - you must use the ReplicationAdmin to add the new ReplicationEndpoint
> - hbase shell add_peer command doesn't support specifying a custom class
> - hbase shell add_peer relies on the newly deprecated ReplicationAdmin 
> addPeer methods
> - ReplicationAdmin addPeer tableCfs is now a Map<TableName, ? extends 
> Collection<String>> instead of a string
> {quote}
> We should fix the add_peer command in the shell at least.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to