[
https://issues.apache.org/jira/browse/HBASE-6778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14292185#comment-14292185
]
stack commented on HBASE-6778:
------------------------------
Just read your write up. Its great. MovedRegionsCleaner not being started looks
like a bug. Suggest fix in new issue. Have the chore run once a day since
seems like it not running has not been an issue up to this. I reattached the
patch on HBASE-11354 to trigger a rebuild. Will commit it if it passes.
Nice stuff like this should go into release note:
{code}
Chore.interrupt() -> ScheduledChore.cancel(mayInterruptWhileRunning = true)
Threads.setDaemonThreadRunning(Chore) ->
ChoreService.scheduleChore(ScheduledChore)
Chore.isAlive -> ScheduledChore.isScheduled()
Chore.getSleeper().skipSleepCycle() -> ScheduledChore.triggerNow()
{code}
Nice numbers on cut in thread count.
Let me give you a bit of feedback on the patch.
> Deprecate Chore; its a thread per task when we should have one thread to do
> all tasks
> -------------------------------------------------------------------------------------
>
> Key: HBASE-6778
> URL: https://issues.apache.org/jira/browse/HBASE-6778
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: Jonathan Lawlor
> Attachments: AFTER_thread_dump.txt, BEFORE_thread_dump.txt,
> HBASE_6778_WIP_v1.patch, HBASE_6778_WIP_v2.patch,
> thread_dump_HMaster.local.out
>
>
> Should use something like ScheduledThreadPoolExecutor instead (Elliott said
> this first I think; J-D said something similar just now).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
