[
https://issues.apache.org/jira/browse/HBASE-6778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294777#comment-14294777
]
stack commented on HBASE-6778:
------------------------------
So, you removed delayed from ConnectionManager.java but you are still starting
up a choreservice? We need to?
How does the choreservice in AuthUtils get shutdown? It never was shutdown it
looks like?
I like the removal of whole classes
Nice doc on ChoreService
nit, if this is suffix, you don't need last '_' on this THREAD_NAME_SUFFIX =
"_ChoreService_";
Is that printChoreServiceDetails called each time and those trace logs
calculate and logged even though we usually don't run at trace? Want to add a
guard? LOG.isTraceEnabled?
Remove this kinda javadoc that is using invisible ink (forgot my lemon juice!)
83 /**
84 *
85 */
86 interface ChoreServicer {
Whats that change in MasterServices.java ? No biggie
Its nice how ScheduledChore slots in nicely in place of Chore; minimal
disruption.
In places like ConnectionCache.java, for sure the chore executor is being shut
down?
Very nice @jonathan lawlor
Anyone else want to take looksee at this nice patch?
> Deprecate Chore; its a thread per task when we should have one thread to do
> all tasks
> -------------------------------------------------------------------------------------
>
> Key: HBASE-6778
> URL: https://issues.apache.org/jira/browse/HBASE-6778
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: Jonathan Lawlor
> Fix For: 2.0.0, 1.1.0
>
> Attachments: AFTER_thread_dump.txt, BEFORE_thread_dump.txt,
> HBASE_6778_WIP_v1.patch, HBASE_6778_WIP_v2.patch, HBASE_6778_v1.patch,
> HBASE_6778_v2.patch, HBASE_6778_v3.patch, HBASE_6778_v3.patch,
> thread_dump_HMaster.local.out
>
>
> Should use something like ScheduledThreadPoolExecutor instead (Elliott said
> this first I think; J-D said something similar just now).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
