[
https://issues.apache.org/jira/browse/HBASE-6778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14292211#comment-14292211
]
stack commented on HBASE-6778:
------------------------------
Looking at your patch and given the recent radical refactor of Connection, I'd
say purge DelayedClosing rather than add it back in as HBASE-11354 has it.
The discussion in HBASE-11354 is too nebulous on what DelayedClosing brings
and its allowed we purge till we figure what is needed in new world.
Don't need 'Thread' on end of name here, redundant: _ChoreServiceThread_
Add this to Server rather than MasterServices and then to RegionServerServices?
ChoreService getChoreService();
Do you not remove the classes you are replacing?
This patch is really good. Let me run it by hadoopqa.
> Deprecate Chore; its a thread per task when we should have one thread to do
> all tasks
> -------------------------------------------------------------------------------------
>
> Key: HBASE-6778
> URL: https://issues.apache.org/jira/browse/HBASE-6778
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: Jonathan Lawlor
> Fix For: 2.0.0, 1.1.0
>
> Attachments: AFTER_thread_dump.txt, BEFORE_thread_dump.txt,
> HBASE_6778_WIP_v1.patch, HBASE_6778_WIP_v2.patch,
> thread_dump_HMaster.local.out
>
>
> Should use something like ScheduledThreadPoolExecutor instead (Elliott said
> this first I think; J-D said something similar just now).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
