[ 
https://issues.apache.org/jira/browse/HBASE-13387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14393153#comment-14393153
 ] 

ramkrishna.s.vasudevan commented on HBASE-13387:
------------------------------------------------

Agree that we will have two code paths with hasArray. But for a Cell that we 
create from the Hfile blocks at the reader level could have an offheap BB or an 
onheap BB from which we could create a cell.  
Now for all the underlying comparisons in the comparator we need to know if the 
Cell is backed by BB or byte[].  We need APIs in cells to deal with BBs anyway 
because current APIs has byte[] only. Now in the comparators how we will do the 
comparison without knowing what the cell is made up of? May be am not getting 
your point here. Sorry about that.

> Add ServerCell an extension to Cell
> -----------------------------------
>
>                 Key: HBASE-13387
>                 URL: https://issues.apache.org/jira/browse/HBASE-13387
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver, Scanners
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>         Attachments: WIP_ServerCell.patch
>
>
> This came in btw the discussion abt the parent Jira and recently Stack added 
> as a comment on the E2E patch on the parent Jira.
> The idea is to add a new Interface 'ServerCell'  in which we can add new 
> buffer based getter APIs, hasArray API etc.  We will keep this interface 
> @InterfaceAudience.Private
> Also we have to change the timestamp and seqId on Cells in server side. We 
> have added new interfaces SettableSequenceId, SettableTimestamp for this. Now 
> if we can add a ServerCell we can add the setter APIs there.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to