[
https://issues.apache.org/jira/browse/HBASE-13387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14483705#comment-14483705
]
stack commented on HBASE-13387:
-------------------------------
Taking a quick look at this patch:
Why is ServerCell showing up in the client package?
(BigDecimalColumnInterpreter, etc)
Whey does createCell create a ServerCell? I'd think it'd create a Cell. If I
wanted a servercell I'd do createServerCell?
Why do all the compares take ServerCell now rather than just Cell? I'd think
ServerCell an implementation detail not to show up on methods generally.
The purge of SettableSid and ts is good.
Looks like could be some benefit going this route -- though this patch has
ServerCell leaking all over as I read it. Mind writing up a few paragraphs on
what you think benefit is Ram?
Sounds like we might also want to have a ReadServerCell that might be different
to WriteServerCell going by recent back and forth.
> Add ServerCell an extension to Cell
> -----------------------------------
>
> Key: HBASE-13387
> URL: https://issues.apache.org/jira/browse/HBASE-13387
> Project: HBase
> Issue Type: Sub-task
> Components: regionserver, Scanners
> Reporter: Anoop Sam John
> Assignee: Anoop Sam John
> Attachments: WIP_ServerCell.patch
>
>
> This came in btw the discussion abt the parent Jira and recently Stack added
> as a comment on the E2E patch on the parent Jira.
> The idea is to add a new Interface 'ServerCell' in which we can add new
> buffer based getter APIs, hasArray API etc. We will keep this interface
> @InterfaceAudience.Private
> Also we have to change the timestamp and seqId on Cells in server side. We
> have added new interfaces SettableSequenceId, SettableTimestamp for this. Now
> if we can add a ServerCell we can add the setter APIs there.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
