[
https://issues.apache.org/jira/browse/HBASE-13387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14487932#comment-14487932
]
ramkrishna.s.vasudevan commented on HBASE-13387:
------------------------------------------------
True and agree to all except one that if adding javadoc is the only way to make
the user use the API combination correctly then the same applies if we throw an
exception also if the 'hasArray' was return false like how java's BB does.
bq.Comparators already had the multiple if else blocks with cell.hasArray()
being check. Now it is instance of check instead of hasArray. I believe later
Java versions are not costly for these instance of checks.
This is good then.
If we don't want to modify Cell then instanceOf is the only way we have. As I
said am fine with any approach we take based on the majority consensus here.
> Add ServerCell an extension to Cell
> -----------------------------------
>
> Key: HBASE-13387
> URL: https://issues.apache.org/jira/browse/HBASE-13387
> Project: HBase
> Issue Type: Sub-task
> Components: regionserver, Scanners
> Reporter: Anoop Sam John
> Assignee: Anoop Sam John
> Attachments: WIP_HBASE-13387_V2.patch, WIP_ServerCell.patch
>
>
> This came in btw the discussion abt the parent Jira and recently Stack added
> as a comment on the E2E patch on the parent Jira.
> The idea is to add a new Interface 'ServerCell' in which we can add new
> buffer based getter APIs, hasArray API etc. We will keep this interface
> @InterfaceAudience.Private
> Also we have to change the timestamp and seqId on Cells in server side. We
> have added new interfaces SettableSequenceId, SettableTimestamp for this. Now
> if we can add a ServerCell we can add the setter APIs there.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
