[ 
https://issues.apache.org/jira/browse/HBASE-13387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14487924#comment-14487924
 ] 

Anoop Sam John commented on HBASE-13387:
----------------------------------------

yes caching is much more imp now..  I hope we will do that. Read path can 
create Cells with cached lengths, offset.

But the old APIs (which are available in Cell.. yes that is type we pass to 
Filter/CPs) works unconditionally.  There is pref hit but no surprise of 
Exceptions.  That is why I would prefer that.  
Regarding new offset APIs, we can clearly say that in javadoc in BufferedCell. 
This is fine IMO..  Any way we plan to give CellUtil APIs for user so that he 
has not deal with instance of checks etc.

Comparators already had the multiple if else blocks with cell.hasArray() being 
check. Now it is instance of check instead of hasArray.  I believe later Java 
versions are not costly for these instance of checks.

> Add ServerCell an extension to Cell
> -----------------------------------
>
>                 Key: HBASE-13387
>                 URL: https://issues.apache.org/jira/browse/HBASE-13387
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver, Scanners
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>         Attachments: WIP_HBASE-13387_V2.patch, WIP_ServerCell.patch
>
>
> This came in btw the discussion abt the parent Jira and recently Stack added 
> as a comment on the E2E patch on the parent Jira.
> The idea is to add a new Interface 'ServerCell'  in which we can add new 
> buffer based getter APIs, hasArray API etc.  We will keep this interface 
> @InterfaceAudience.Private
> Also we have to change the timestamp and seqId on Cells in server side. We 
> have added new interfaces SettableSequenceId, SettableTimestamp for this. Now 
> if we can add a ServerCell we can add the setter APIs there.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to