[ 
https://issues.apache.org/jira/browse/HBASE-13450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14508786#comment-14508786
 ] 

ramkrishna.s.vasudevan commented on HBASE-13450:
------------------------------------------------

bq.Why write anything if comparator is null?
Felt that the Bytes.writeByteArray would need some valid byte[].  But saw that 
it writes a 0 vint if the byte[] is null.  So now for the Bytes.RAW_COMPARATOR 
case we will not write any class name for the Bloom case.

> Purge RawBytescomparator from the writers and readers after HBASE-10800
> -----------------------------------------------------------------------
>
>                 Key: HBASE-13450
>                 URL: https://issues.apache.org/jira/browse/HBASE-13450
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0
>
>         Attachments: HBASE-13450.patch, HBASE-13450_2.patch, 
> HBASE-13450_3.patch
>
>
> Currently KeyValue.RAW_COMPARATOR is written in the Trailer of the HFiles.  
> Ideally this need not be persisted to the trailer of the Hfiles because only 
> the ROW bloom and the meta index blocks uses this. Currently RAW_COMPARATOR 
> is also of type KVComparator.
> HBASE-10800 would introduce CellComparator and would expect only cells to be 
> compared.  We cannot have RAW_COMPARATOR a type of CellComparator.  Hence it 
> is better to avoid writing the RAW_COMPARATOR to the FFT and whereever we 
> need RAW_COMPARATOR we will directly use it as Bytes.BYTES_RAWCOMPARATOR.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to