[
https://issues.apache.org/jira/browse/HBASE-13450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510655#comment-14510655
]
ramkrishna.s.vasudevan commented on HBASE-13450:
------------------------------------------------
bq.So while doing HBASE-10800 You will conevrt the calling method to take
CellComparator? Then this method impl also will change?
Ideally I would just call the API without any comparator. Expecting it to work
with Bytes.BYTES_RAWCOMPARATOR.
bq.May be we have to direct that also in @deprecated?
I would think that for any KV based comparison we will move to the binarySearch
with CellComparator only. (for now). After we change even the blockKeys to be
Cell based then ideally we will not end up in this case of byte[](kv format)
and both would become cells.
bq.public static <T> int binarySearch(T[] arr, T key, Comparator<T>
comparator) {
This thing is fine. I wanted to do it with Comparator<?>. But if we are
ensuring that both sides are Cells then we may not need this much generic API?
bq.Similar way you want to return null for
Ideally this case is not going to happen. But better to add being a static
method. Will add that in the else if just above this if condition.
> Purge RawBytescomparator from the writers and readers after HBASE-10800
> -----------------------------------------------------------------------
>
> Key: HBASE-13450
> URL: https://issues.apache.org/jira/browse/HBASE-13450
> Project: HBase
> Issue Type: Sub-task
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 2.0.0
>
> Attachments: HBASE-13450.patch, HBASE-13450_2.patch,
> HBASE-13450_3.patch, HBASE-13450_4.patch
>
>
> Currently KeyValue.RAW_COMPARATOR is written in the Trailer of the HFiles.
> Ideally this need not be persisted to the trailer of the Hfiles because only
> the ROW bloom and the meta index blocks uses this. Currently RAW_COMPARATOR
> is also of type KVComparator.
> HBASE-10800 would introduce CellComparator and would expect only cells to be
> compared. We cannot have RAW_COMPARATOR a type of CellComparator. Hence it
> is better to avoid writing the RAW_COMPARATOR to the FFT and whereever we
> need RAW_COMPARATOR we will directly use it as Bytes.BYTES_RAWCOMPARATOR.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
