[
https://issues.apache.org/jira/browse/HBASE-13450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14509466#comment-14509466
]
ramkrishna.s.vasudevan commented on HBASE-13450:
------------------------------------------------
bq.Do the overrides work? Isn't RawComparator<Cell> a subclass of
Comparator<Cell>?
I will not do this override. Will copy the implementation once again to the
method accepting RawComparator. Because we are not going to remove
KVComparator even after HBASE-10800 and that is going to be deprecated. In the
current code KVComparator implements RawComparator<Cell> and CellComparator
implements Comparator<Cell>. After HBASE-10800 there will not be any
RawComparator<Cell>. So we will leave that API as it is - only thing is the
implementation is going to repeat. I think that would be better. Thanks for
the reviews. Will commit unless objections.
> Purge RawBytescomparator from the writers and readers after HBASE-10800
> -----------------------------------------------------------------------
>
> Key: HBASE-13450
> URL: https://issues.apache.org/jira/browse/HBASE-13450
> Project: HBase
> Issue Type: Sub-task
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 2.0.0
>
> Attachments: HBASE-13450.patch, HBASE-13450_2.patch,
> HBASE-13450_3.patch
>
>
> Currently KeyValue.RAW_COMPARATOR is written in the Trailer of the HFiles.
> Ideally this need not be persisted to the trailer of the Hfiles because only
> the ROW bloom and the meta index blocks uses this. Currently RAW_COMPARATOR
> is also of type KVComparator.
> HBASE-10800 would introduce CellComparator and would expect only cells to be
> compared. We cannot have RAW_COMPARATOR a type of CellComparator. Hence it
> is better to avoid writing the RAW_COMPARATOR to the FFT and whereever we
> need RAW_COMPARATOR we will directly use it as Bytes.BYTES_RAWCOMPARATOR.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
