[
https://issues.apache.org/jira/browse/HBASE-13729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14573859#comment-14573859
]
stack commented on HBASE-13729:
-------------------------------
Do you want to say why the values are empty in hbase-default.xml in the
description text? If you don't, empty values looks strange. Otherwise, patch
looks good to me.
> Old hbase.regionserver.global.memstore.upperLimit and lowerLimit properties
> are ignored if present
> --------------------------------------------------------------------------------------------------
>
> Key: HBASE-13729
> URL: https://issues.apache.org/jira/browse/HBASE-13729
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Affects Versions: 2.0.0, 1.0.1, 1.1.0
> Reporter: Esteban Gutierrez
> Assignee: Esteban Gutierrez
> Priority: Critical
> Attachments:
> 0001-HBASE-13729-Old-hbase.regionserver.global.memstore.u.patch,
> HBASE-13729.2.patch, HBASE-13729.3.patch
>
>
> If hbase.regionserver.global.memstore.upperLimit or lowerLimit are present we
> should use them instead of hbase.regionserver.global.memstore.size or
> hbase.regionserver.global.memstore.size.lower.limit respectively. The current
> implementation of HeapMemorySizeUtil.getGlobalMemStorePercent() and
> getGlobalMemStoreLowerMark() asumes that if the new properties are not
> defined then we should use the old configurations, however the new properties
> are defined in hbase-default.xml which makes the old configuration names
> useless and this has a direct impact when doing a rolling upgrade and
> hbase-site.xml hasn't been changed to handle the new property names
> exclusively.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
