[
https://issues.apache.org/jira/browse/HBASE-13729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14573940#comment-14573940
]
Hadoop QA commented on HBASE-13729:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12737731/HBASE-13729.3.patch
against master branch at commit bb62d5b2e8db1677568723bb8d0d8ea4fd2c6f46.
ATTACHMENT ID: 12737731
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/14293//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/14293//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/14293//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/14293//console
This message is automatically generated.
> Old hbase.regionserver.global.memstore.upperLimit and lowerLimit properties
> are ignored if present
> --------------------------------------------------------------------------------------------------
>
> Key: HBASE-13729
> URL: https://issues.apache.org/jira/browse/HBASE-13729
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Affects Versions: 2.0.0, 1.0.1, 1.1.0
> Reporter: Esteban Gutierrez
> Assignee: Esteban Gutierrez
> Priority: Critical
> Attachments:
> 0001-HBASE-13729-Old-hbase.regionserver.global.memstore.u.patch,
> HBASE-13729.2.patch, HBASE-13729.3.patch, HBASE-13729.4.patch
>
>
> If hbase.regionserver.global.memstore.upperLimit or lowerLimit are present we
> should use them instead of hbase.regionserver.global.memstore.size or
> hbase.regionserver.global.memstore.size.lower.limit respectively. The current
> implementation of HeapMemorySizeUtil.getGlobalMemStorePercent() and
> getGlobalMemStoreLowerMark() asumes that if the new properties are not
> defined then we should use the old configurations, however the new properties
> are defined in hbase-default.xml which makes the old configuration names
> useless and this has a direct impact when doing a rolling upgrade and
> hbase-site.xml hasn't been changed to handle the new property names
> exclusively.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
